Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise max objective guests to 50000 #19454

Merged

Conversation

Gymnasiast
Copy link
Member

@Gymnasiast Gymnasiast commented Feb 21, 2023

Requested in the Discord chat.

Closes #15849.

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Feb 22, 2023

65000 seems a bit too high imo, wouldn't that only leave about 500 entity slots open for vehicles, staff, balloons, ducks, etc?
I feel like that'd be something you'd hit pretty fast in a park designed to contain that many guests.
I think 50000 would be a bit more reasonable as that would give a good buffer of about 15000 entities between the max objective cap and the entity limit.

I also think it would be a good idea to raise the 7000 guest soft cap in openrct2/world/Park.cpp as it was clearly designed with the old objective & entity limits in mind, probably setting that to a number around 57000 would make the most sense as that's a number roughly between the max objective cap and the entity limit similar to how it was with the vanilla limits. Or would that be out of the scope of this PR?

@Gymnasiast Gymnasiast force-pushed the refactor/max-guests-in-objective branch from 095081a to 88bae70 Compare February 22, 2023 11:07
@Gymnasiast
Copy link
Member Author

I think that would be out of scope, though that’s ultimately for the team to say.

@Gymnasiast Gymnasiast changed the title Raise max objective guests to 65000 Raise max objective guests to 50000 Feb 22, 2023
@Gymnasiast Gymnasiast force-pushed the refactor/max-guests-in-objective branch from 88bae70 to 7d998a6 Compare February 22, 2023 11:09
Copy link
Member

@Broxzier Broxzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50,000 is a good compromise, which also doesn't seem like a magic number to the players.

@Broxzier Broxzier merged commit 28476cb into OpenRCT2:develop Feb 22, 2023
@Broxzier Broxzier added this to the v0.4.4 milestone Feb 22, 2023
@Gymnasiast Gymnasiast deleted the refactor/max-guests-in-objective branch February 22, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario objectives only allow a maximum of 5000 guests.
3 participants