Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hybrid RC Liftspeed & default ride music #21659

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

karst
Copy link
Member

@karst karst commented Mar 23, 2024

In this PR I have upped the lift speed of the RMC Hybrid to reflect the liftspeed of Lightning Rod, which should crest the lifthill with 13 mph, or 21 kmh respectively. I suspect the average lift speed to be about 11 mph / 17 kmh.

https://youtu.be/vlWbtwIAnXE?t=156

With this I have also updated the ride music to use Rock style 4 by default.

@karst karst added the discussion Some input from team members is wanted. label Mar 23, 2024
@Gymnasiast Gymnasiast self-requested a review March 23, 2024 21:44
@Gymnasiast Gymnasiast added this to the After v0.4.10 milestone Mar 31, 2024
@AaronVanGeffen AaronVanGeffen removed this from the After v0.4.10 milestone May 18, 2024
Copy link

github-actions bot commented Jul 8, 2024

This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the stale-pr label. If you're awaiting feedback from a developer, please send us a reminder (either here or on Discord).

@karst karst removed the stale-pr label Jul 8, 2024
@Gymnasiast
Copy link
Member

Left this for far too long. Sorry about that.

I think it might be better not to do this, for two reasons:

  • The Hybrid is already a very powerful roller coaster, having a 21 km/h chainlift (even if realistic) might upset balance further.
  • It now defaults to a music object that is not always available, which in practical terms means it will now default to a blank music style.

@karst
Copy link
Member Author

karst commented Aug 2, 2024

* The Hybrid is already a very powerful roller coaster, having a 21 km/h chainlift (even if realistic) might upset balance further.

I have discussed this with Marcel and a few others, shouldn't impact the balance, in the grand scale of things it's not big of a change.

* It now defaults to a music object that is not always available, which in practical terms means it will now default to a blank music style.

That's true, but this is going to become an issue in the future in general. For OpenScenarios where RCT2 music will not be enabled by default but the OpenMusic objects instead.

Tho we should probably implement fallback for that if we do want to implement this and that might not be right for this PR.

@@ -18,6 +18,7 @@
- Change: [#7248] Small mini-maps are now centred in the map window.
- Change: [#20240] Heavy snow and blizzards now make guests buy and use umbrellas.
- Change: [#21214] Wacky Worlds and Time Twister’s scenario names now match their park names.
- Change: [#21659] Up Hybrid Roller Coaster liftspeed to 11mph/17kmh.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up Hybrid Roller Coaster maximum liftspeed to 11mph/17kmh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Change: [#21659] Up Hybrid Roller Coaster liftspeed to 11mph/17kmh.
- Change: [#21659] Increase the Hybrid Roller Coaster’s maximum lift speed to 17 km/h (11 mph).

@Gymnasiast
Copy link
Member

Very well, are you okay with doing just the lift speed increase and keeping the music style change out (at least until we have some sort of fallback)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Some input from team members is wanted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants