Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21829: {POP16}{POP16} in Scenario editor #21830

Merged
merged 1 commit into from Apr 23, 2024

Conversation

733737
Copy link
Contributor

@733737 733737 commented Apr 17, 2024

Remove notation from string

@733737 733737 changed the title fix #21829 fix #21829 {POP16}{POP16} in Scenario editor Apr 17, 2024
@Gymnasiast Gymnasiast linked an issue Apr 17, 2024 that may be closed by this pull request
@Gymnasiast
Copy link
Member

We’ll have to check if the string is used anywhere else. Otherwise, we might have to duplicate it and have one version with and one version without the formatting codes.

Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, needs a changelog entry. E.g.:

Fix: [#21829] When creating a new park, the default name contains formatting codes.

@Gymnasiast Gymnasiast added this to the v0.4.11 milestone Apr 18, 2024
@733737 733737 force-pushed the ducknificent branch 3 times, most recently from f8fd8b5 to b9abb81 Compare April 18, 2024 23:00
Remove notation from string
@Gymnasiast Gymnasiast changed the title fix #21829 {POP16}{POP16} in Scenario editor Fix #21829: {POP16}{POP16} in Scenario editor Apr 19, 2024
@Gymnasiast Gymnasiast merged commit 30d314e into OpenRCT2:develop Apr 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario editor shows {POP16}{POP16} for some reason
2 participants