Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #21421: Replace constants that use #define with ones that use constexpr #21883

Merged
merged 8 commits into from
May 18, 2024
Merged

Part of #21421: Replace constants that use #define with ones that use constexpr #21883

merged 8 commits into from
May 18, 2024

Commits on Apr 21, 2024

  1. rename MAX_SCROLLING_TEXT_MODES to kMaxScrollingTextModes

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    5321b0c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Rename FRAME_RENDERING_START to kFrameRenderingStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    aca6cc3 View commit details
    Browse the repository at this point in the history

  2. Rename FRAME_EFFECTS_START to kFrameEffectStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0c15483 View commit details
    Browse the repository at this point in the history

  3. Rename CONTROLS_GROUP_START to kControlsGroupStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5a8f605 View commit details
    Browse the repository at this point in the history

  4. Rename THEMES_GROUP_START to kThemesGroupStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    76e2418 View commit details
    Browse the repository at this point in the history

  5. Rename TOOLBAR_GROUP_START to kToolbarGroupStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    92acdb0 View commit details
    Browse the repository at this point in the history

  6. Rename TITLE_SEQUENCE_START to kTitleSequenceStart

    @rohan4412 @AaronVanGeffen
    rohan4412 authored and AaronVanGeffen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    382190e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Address outstanding review comments

    @AaronVanGeffen
    AaronVanGeffen committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b06c4c9 View commit details
    Browse the repository at this point in the history