Refactor more constants in TrackPaint.h #21942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisozaur
approved these changes
May 1, 2024
Harry-Hopkinson
force-pushed
the
refactor-constants-TrackPaint.h
branch
2 times, most recently
from
97854b8
to
8ea09ff
Compare
|
Seems this needs an update once again and could be merged soon |
Harry-Hopkinson
force-pushed
the
refactor-constants-TrackPaint.h
branch
from
8ea09ff
to
66d58bc
Compare
Harry-Hopkinson
force-pushed
the
refactor-constants-TrackPaint.h
branch
from
814f00f
to
e942a45
Compare
tupaschoal
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename more constants to follow the new notation in TrackPaint.h. Move
extern conststoconstexpr.