-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce progress/loader window #22065
Introduce progress/loader window #22065
Conversation
Nice work! One though that I had: since most loading sessions will contain both status updates with just text, and updates with progress, we should maybe make sure that the respective windows look otherwise similar (i.e. use the same colours, be the same size, avoid text jumping around, ...). Doing so would make it look "calmer", for lack of a better word. |
2410c42
to
b8dc2db
Compare
e33877f
to
3aa0f91
Compare
Fixup: deal with -Wdeprecated-anon-enum-enum-conversion warning
This comment was marked as resolved.
This comment was marked as resolved.
6e3d890
to
6bc6322
Compare
@Basssiiie I've decreased the drawing canvas by 1px on every side, effectively adding a slight margin. Here's what it looks like now: The demo videos in the OP have been updated to reflect this change. |
With the PNGs now cropped and optimised as well, I think this PR is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick test after the last changes and functionally it all LGTM! 😄
7ed1612
to
b9624ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the code and found only a small thing to nag about. Will proceed to test next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing revealed no bugs.
Personally, I would have put the train in the middle for progress bar with indefinite progress, rather than at ~30%, but I’m not willing to let that block my approval.
1740cf3
to
c9de564
Compare
I am, because the intention was to draw it halfway. Turns out my code was drawing the tip of the vehicle at 50%, rather than centring it there. I've now addressed that, and the result is in 2f05dc9. |
OK, I’m not at home so I cannot test it easily. I’ll just trust you on this one, you can merge as far as I’m concerned ^^ |
This PR introduces a dedicated ProgressWindow to denote loading progress in a playful, graphical way. This is to be used instead of the NetworkStatus info when progress has measurable increments.
Preloader scene (slowed down):
Screen.Recording.2024-05-21.at.19.11.05.mov
Joining a server:
Screen.Recording.2024-05-21.at.19.11.17.mov
Track style reel:
Screen.Recording.2024-05-20.at.14.59.32.mov
To do: