Pause state setter for plugin API #22090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can try this feature out with this plugin: https://github.com/spacek531/ParkPauser/blob/master/src/ParkPauser.js |
spacek531
force-pushed
the
api/pause
branch
2 times, most recently
from
9bff9d2
to
31fff18
Compare
spacek531
force-pushed
the
api/pause
branch
2 times, most recently
from
8880c9c
to
2265d75
Compare
|
I'm not sure if we should introduce even more unsafe game state manipulations like this one, but it does not look too problematic. |
Basssiiie
reviewed
Jun 1, 2024
Basssiiie
approved these changes
Jun 8, 2024
janisozaur
approved these changes
Jun 14, 2024
be ignored, and an empty message aborts the commit.
|
Rebased |
|
Are there any current blockers to merging this? |
Gymnasiast
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is impossible to set pause state on loading without losing 1 frame when hooked to
map.changedand it is impossible to set pause state before park save when hooked tomap.save. This PR fixes that by allowing plugins to set pause state directly.Setter is disabled in networked mode because it is not network-safe to call PauseToggle without extra stuff that the game action does perfectly well.