Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract flags access in track design scenery #22167

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Abstract flags access in track design scenery #22167

merged 2 commits into from
Jun 19, 2024

Conversation

Gymnasiast
Copy link
Member

@Gymnasiast Gymnasiast commented Jun 14, 2024 •
edited
Loading

Removes direct access/bitshifting in the flags field and replaces it with member functions.

janisozaur
janisozaur approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@janisozaur janisozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, but I wish these flags had named bitmasks

ZeeMaji
ZeeMaji approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@ZeeMaji ZeeMaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested placing 10 track designs, they still seem to be importing correctly.

I also tested resaving 5 of them, they saved correctly.

Everything seems to be working as expected.

spacek531
spacek531 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@spacek531 spacek531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested numerous path shapes backwards and forwards, I tested diagonal scenery. Everything worked.

@Gymnasiast Gymnasiast merged commit a82d398 into OpenRCT2:develop Jun 19, 2024
22 checks passed
@Gymnasiast Gymnasiast deleted the refactor/more-trackdesign-2 branch June 19, 2024 10:15
@Gymnasiast Gymnasiast added this to the v0.4.12 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisozaur janisozaur janisozaur approved these changes

@spacek531 spacek531 spacek531 approved these changes

@ZeeMaji ZeeMaji ZeeMaji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gymnasiast @janisozaur @spacek531 @ZeeMaji