Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Update #2605

Merged
merged 179 commits into from
Jan 10, 2016
Merged

Vehicle Update #2605

merged 179 commits into from
Jan 10, 2016

Conversation

duncanspumpkin
Copy link
Contributor

Its taken a little while but vehicle update is now ready for extensive testing.

@HaasJona
Copy link
Contributor

HaasJona commented Jan 2, 2016

Can confirm the wrong door sound.

Also, intensity rating seems to be calculated incorrectly, in the attached txt file (change file extension to sv6), the inverted shuttle coaster has an intensity of about 10.5 in the normal branch and 58.36 in the vehicle update branch. Also, the average speed is way too high.

bildschirmfoto von 2016-01-02 12-52-17

door.txt

@duncanspumpkin
Copy link
Contributor Author

@HaasJona that should fix both of the issues you have found.

Labeled map_flag (1<<5) as block break closed as well.
@HaasJona
Copy link
Contributor

HaasJona commented Jan 2, 2016

@duncanspumpkin looks good

@Broxzier
Copy link
Member

Broxzier commented Jan 2, 2016

I noticed that go-karts can get stuck in this branch. In the attached file there already are a few karts all on the same spot because the first one got stuck. You're almost guaranteed to get one stuck by letting people ride this track, not always on the same spot though, I think it has something to do with when they want to switch lane.

[RI] Go Karts Challenge.zip

Oping this park in this branch leaves them stuck, opening them in another makes them all spread out and continue driving.

janisozaur and others added 3 commits January 3, 2016 00:59
This is just whitespace fixup for all files affected in vehcile-update
branch.
@danidoedel
Copy link
Contributor

The 3D cinema seems to unload its passengers immediately after they joined.

edit:
Trains getting stuck at the station (unloading passengers) after they broke down and got repaired

@duncanspumpkin
Copy link
Contributor Author

Okay i've fixed the race cars and the 3D cinema.

@danidoedel
Copy link
Contributor

Rides never call a mechanic if they have a vehicle malfunction.

@Gymnasiast
Copy link
Member

Haven't been able to reproduce the sound issue I had anymore.

@duncanspumpkin
Copy link
Contributor Author

@danidoedel I've fixed the two issues you had with the mechanics not being called and trains getting stuck at the station after a fix.

@duncanspumpkin duncanspumpkin removed the testing required PR needs to be tested before it is merged. label Jan 10, 2016
duncanspumpkin added a commit that referenced this pull request Jan 10, 2016
@duncanspumpkin duncanspumpkin merged commit 8997f2a into develop Jan 10, 2016
@duncanspumpkin duncanspumpkin deleted the vehicle-update branch January 11, 2016 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants