MP groups and permissions

[zsilencer]

[IntelOrca]

Impressive.
Currently anyone with full access can set other clients including themselves to spectator / full access. This should probably only be allowed by host. Alternatively there could just an additional "moderator" permission level.

Once this gets merged, we can all start making the interface read-only when player is a spectator. E.g. changing drop downs to just plain text.

[zsilencer]

I plan on expanding the group management tab so that you can create new groups with fine grained control, such as allowing only certain game commands, and boundaries on the map where things can be placed, etc. Right now just wanted these two defaults, and I made it so the host always has full access, with a setting of a default group of any players joining. So you can just have you and your buddies working on a park without needing a password, and can let anyone join, watch and chat.

Making everything in the interfaces read-only might be a big pain, and they get a error box saying permission denied when they try things, so it shouldn't be too hard for users to understand.

[IntelOrca]

Currently clients with full access can change the permissions of other clients, this shouldn't be allowed for the time being.

[janisozaur]

Cool stuff. Out of curiosity – does OpenTTD has something like that?

[zsilencer]

@IntelOrca K I have this mostly complete now, and have added a default User group that does not have permission to modify or assign groups to address your concern. Maybe some people can test this.

[IntelOrca]

@LRFLEW could you xcode this PR?

[janisozaur]

size_t is unsigned, so this is always false.

[LRFLEW]

@zsilencer I made a PR against your branch to fix the Xcode project. I also fixed one of @janisozaur's comments, as it was causing a warning in Xcode.

[zsilencer]

still have some things to change so do not merge yet

[IntelOrca]

This reminds me of Locomotion which showed you what other players were looking at.

[IntelOrca]

Clients can still pick up and move guests even though the guest permission is disabled.

[zsilencer]

alright i fixed that, let me know if anyone finds any other issues.

[IntelOrca]

Does it save the groups and permissions?

[janisozaur]

w00t! https://www.reddit.com/r/openrct2/comments/42fsth/new_multiplayer_permissions_system_just_got_merged/