Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure MinGW to consume Vista+ APIs #4638

Merged
merged 2 commits into from Oct 17, 2016
Merged

Conversation

janisozaur
Copy link
Member

This is proof of concept and may require some discussion. This effectively drops XP support we've sort-of had until now, even though we claimed we don't have it.

@LRFLEW
Copy link
Contributor

LRFLEW commented Oct 17, 2016

Would it work to put these defines in CMakeLists_mingw.txt? It might be cleaner to do it that way if it makes sense.

@janisozaur
Copy link
Member Author

@LRFLEW I'm not sure if this would have to go into CMakeLists.txt or can it be in CMakeLists_mingw.txt. The current way is just a tiny bit easier and more contained, but we can do that with CMake as well.

@IntelOrca
Copy link
Contributor

Visual Studio can still compile for XP using these APIs, but I am not sure what happens when executed.

@LRFLEW
Copy link
Contributor

LRFLEW commented Oct 17, 2016

BTW, something weird happened involving this PR that caused the CI build to be pushed to openrct2.org. The build (in theory) shouldn't be any different from the previous one, so I'm not so worried about the API pulling the wrong build as the "current" one, but it is worth noting that it happened.

https://openrct2.org/downloads/develop/e67d54c

@IntelOrca
Copy link
Contributor

@LRFLEW its because @janisozaur pushed the branch to the main repo rather than his fork.

@janisozaur
Copy link
Member Author

it still shouldn't push to .org, I'll have to check that

@IntelOrca
Copy link
Contributor

I thought we made it so that it only pushed it .org if it begins with push/

@janisozaur
Copy link
Member Author

I thought so too, but there must be a bug in the guard I made.

@IntelOrca IntelOrca merged commit 2bf4ded into develop Oct 17, 2016
@janisozaur janisozaur deleted the janisozaur-mingw-test branch October 18, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants