Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RCT1 edge styles #7010

Merged
merged 1 commit into from Jan 13, 2018
Merged

Conversation

Gymnasiast
Copy link
Member

SV6 reserves 4 bits for the terrain edge. This means that it can actually save 16 different land types.

This PR uses the remaining 12 slots to add the RCT1 terrain edge styles.

Things to note:

  • It only adds edge styles, not surface styles
  • For people who don't have RCT1, there is no visual difference, it will just draw rock.

@Gymnasiast Gymnasiast changed the title Terrain edges 2 Add RCT1 edge styles Jan 12, 2018
@AaronVanGeffen
Copy link
Member

AaronVanGeffen commented Jan 12, 2018

Really nice to see some work on getting these RCT1 features in OpenRCT2! However, if you don't have RCT1 linked, currently, this happens:
screenshot_20180112_141429

@IntelOrca
Copy link
Contributor

This is adding new data to SV6. It would be something we'd have to support forever more when importing SV6 when we have a new save format which will use objects for wall textures.

@Gymnasiast
Copy link
Member Author

Gymnasiast commented Jan 12, 2018

@AaronVanGeffen Hm, I thought I removed the images from the drop down. Hold on.

@IntelOrca I'm aware of that. If you think it's not worth the effort, you can close this.

@JeroenDStout
Copy link
Contributor

@IntelOrca Wall styles would always require some bits to be used, this just uses all of them (which I understand are already allotted). Does that really add new data to the SV6 or just use the existing data more thoroughly? It is not unlike using unused peep/ride data, like flags for paths to reserve them at crossings.

@Gymnasiast
Copy link
Member Author

Quoting IntelOrca from private chat:
"its only going to just be a larger array which we already have anyway for SC4. I'd just thought I'd mention it."

What I think he means is that we will need to take it into account when importing S6 files.

@rwjuk
Copy link
Contributor

rwjuk commented Jan 12, 2018

What happens if you load an SV6 with an extra style in RCT2, or RCTC? Will it just show rock?

@Gymnasiast
Copy link
Member Author

It will either show corrupted sprites or crash.

@Lastorder-DC
Copy link
Contributor

Lastorder-DC commented Jan 13, 2018

RCT1 Terror Town(SC96.SC4) imported with RCT2

pr
OpenRCT2 with this patch

without_pr
OpenRCT2 without this patch

rct2
Vanila RCT2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants