Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en-GB.txt #8042

Closed
wants to merge 1 commit into from
Closed

Update en-GB.txt #8042

wants to merge 1 commit into from

Conversation

IntelOrca
Copy link
Contributor

Make the casing of 'open custom content folder' consistent with the other menu items on the toolbox.

Make the casing of 'open custom content folder' consistent with the other menu items on the toolbox.
@Gymnasiast
Copy link
Member

The rest of the items are all names for tools, except "Convert saved game to scenario". Names in English typically capitalise more words.

Basically, I don't think this change is correct.

@pizza2004
Copy link
Contributor

It's not grammatically correct if we look at this as a sentence, but I think it /looks/ better if it matches the other menu items personally, and this isn't meant to be a sentence. You could also make an argument that it /is/ the name, being the name of a menu item.

Grammar is more of a suggestion than a rule, used to make sure that stuff is consistent so that communication is easier, and making this capitalized doesn't harm communication at all.

@qwertychouskie
Copy link
Contributor

IMO this should stay the same, and "Convert Saved Game to Scenario" should maybe be changed to "Convert saved game to scenario". The difference is that e.g. "Track Editor" is a title while "Open custom content folder" isn't a title, it's an action.

@Gymnasiast
Copy link
Member

For the reasons mentioned above, I'm closing this PR.

@Gymnasiast Gymnasiast closed this Oct 31, 2018
qwertychouskie added a commit to qwertychouskie/OpenRCT2 that referenced this pull request Nov 1, 2018
@qwertychouskie qwertychouskie mentioned this pull request Nov 1, 2018
Gymnasiast pushed a commit that referenced this pull request Nov 1, 2018
@AaronVanGeffen AaronVanGeffen deleted the en-gb/correct-case branch July 13, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants