New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue#8725: refactoring _currentTrackBegin and _previousTrackPiece in Ride.cpp to use CoordsXYZ struct #8759
Conversation
…inZ to use a CoordsXYZ struct
…ieceZ to use a CoordsXYZ struct
You will also need to apply changes to other source files which use |
@@ -289,7 +289,7 @@ static constexpr const rct_string_id RideConfigurationStringIds[] = { | |||
STR_HELIX_DOWN_LEFT, // 108 | |||
STR_HELIX_DOWN_RIGHT, // 109 | |||
STR_BASE_SIZE_2_X_2, // 110 | |||
STR_BASE_SIZE_4_X_4, // 111 | |||
STR_BASE_SIZE_4_X_4, // ****111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure what this change has been made for. Please revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Almost there just need to make a formatting adjustment to keep the clang-format ci happy.
If your unsure how to find more information on that look below where it says continuous-integration/travis-ci/pr — The Travis CI build failed
and click details. Then when on Travis select the clang format option and it will tell you which line needs adjusting.
Removed accidental addition to comment
added new line to stay within line length limit
In the Ride.cpp file,
were refactored to use the CoordsXYZ struct
such that
becomes
The same refactoring logic was used to refactor _previousTrackPiece.