Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from RelWithDebInfo to MinSizeRel + -g for Linux amd64 #9404

Merged
merged 1 commit into from Jun 26, 2019

Conversation

janisozaur
Copy link
Member

In #9357 it was found that
the archive to be uploaded is too big, over 32MiB quota imposed by
Google App Engine. To alleviate that, switch GCC to -Os -g to help
reduce the code size a bit.

Fixes #9357

@janisozaur
Copy link
Member Author

Let's see how big the archive is.

Ping @JarnoVgr

@janisozaur
Copy link
Member Author

I have some other ideas how to further improve that:

  1. Use system gtest. While there is a warning, I think I know what I'm doing™ and it should be fine.
  • This should have the benefit of exposing cmake's gtest_discover_tests
  1. Group the tests into common binary. Multiple smaller binaries are usually quicker to build than large one and easier to start porting, but I'm willing to sacrifice that for the sake of being able to produce binaries we distribute

In #9357 it was found that
the archive to be uploaded is too big, over 32MiB quota imposed by
Google App Engine. To alleviate that, switch GCC to `-Os -g` to help
reduce the code size a bit.

Fixes #9357
@janisozaur
Copy link
Member Author

Any of the gtest changes won't help, as tests are not being packaged.

@janisozaur
Copy link
Member Author

Resulting package is 31752767 bytes.

33554432 (32MiB) - 31752767 = 1801665 ≃ 1760kiB

@Gymnasiast Gymnasiast merged commit c141e58 into develop Jun 26, 2019
@AaronVanGeffen AaronVanGeffen deleted the janisozaur-patch-2 branch July 13, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis-ci linux build script is missing curl
2 participants