Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CUD operations returning Task #226

Merged

Conversation

niklas-holma
Copy link
Contributor

@niklas-holma niklas-holma commented May 7, 2020

Fix #219
async Task support for CUD operations including Entity Action (Query and Invoke already had support)
Integration Tests for both C# and VB versions of client code generation

@CLAassistant
Copy link

CLAassistant commented May 7, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Daniel-Svensson Daniel-Svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few comments.

Could you please add "Fixes #219" To the PR description to link it to the issue

@Daniel-Svensson
Copy link
Member

it would be nice (but not mandatory) if you could update the changelog.md with some detail as well

@niklas-holma niklas-holma marked this pull request as ready for review May 8, 2020 12:59
@Daniel-Svensson Daniel-Svensson self-assigned this May 8, 2020
Copy link
Member

@Daniel-Svensson Daniel-Svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good, now you only need to make the build pass and have a look if the sonarcloud check reports any relevant issues to fix (visible a short while after build is successfull)

@Daniel-Svensson
Copy link
Member

@papaneko I had a look at the build and it seems you get compile error because UnwrapTaskResult is private.

I suggest changing it to private protected instead to fix the build

@Daniel-Svensson
Copy link
Member

It seems one test is failing, I am running a new build against master and waiting to see if the same test fails there https://dev.azure.com/OpenRiaServices/OpenRiaServices/_build/results?buildId=513&view=results

@Daniel-Svensson
Copy link
Member

Daniel-Svensson commented May 11, 2020

it seems like the failing tests succeeds in master but not for this PR.

It needs a bit further investigation, i've retriggered the build for the PR and it still failed.
It is hard to say at the moment if it might be a timing related issue or something else.

It does look like there is something in this PR which triggers the test failure

@sonarcloud
Copy link

sonarcloud bot commented May 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Daniel-Svensson Daniel-Svensson changed the title async Task support for CUD operations Support CUD operations returning Task May 18, 2020
@Daniel-Svensson Daniel-Svensson merged commit 4bbde68 into OpenRIAServices:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityAction and CRUD which are Async should support returning Task
3 participants