-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CUD operations returning Task #226
Support CUD operations returning Task #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have a few comments.
Could you please add "Fixes #219" To the PR description to link it to the issue
...est/Desktop/OpenRiaServices.Common.DomainServices.Test/Mocks/ServerSideAsyncDomainService.cs
Outdated
Show resolved
Hide resolved
...est/Desktop/OpenRiaServices.Common.DomainServices.Test/Mocks/ServerSideAsyncDomainService.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Server/Framework/Data/DomainService.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Server/Framework/Data/DomainService.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Server/Framework/Data/DomainService.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Outdated
Show resolved
Hide resolved
it would be nice (but not mandatory) if you could update the changelog.md with some detail as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good, now you only need to make the build pass and have a look if the sonarcloud check reports any relevant issues to fix (visible a short while after build is successfull)
src/OpenRiaServices.DomainServices.Client/Test/Client.Test/Data/ServerSideAsyncTests.cs
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Server/Framework/Data/DomainService.cs
Outdated
Show resolved
Hide resolved
src/OpenRiaServices.DomainServices.Server/Framework/Data/DomainService.cs
Outdated
Show resolved
Hide resolved
@papaneko I had a look at the build and it seems you get compile error because UnwrapTaskResult is private. I suggest changing it to |
It seems one test is failing, I am running a new build against master and waiting to see if the same test fails there https://dev.azure.com/OpenRiaServices/OpenRiaServices/_build/results?buildId=513&view=results |
it seems like the failing tests succeeds in master but not for this PR. It needs a bit further investigation, i've retriggered the build for the PR and it still failed. It does look like there is something in this PR which triggers the test failure |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Fix #219
async Task support for CUD operations including Entity Action (Query and Invoke already had support)
Integration Tests for both C# and VB versions of client code generation