Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Crafter #296

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Support Crafter #296

merged 5 commits into from
Mar 22, 2024

Conversation

WentseChen
Copy link
Collaborator

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make format (required).

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 74.11%. Comparing base (8f2423c) to head (cf4661a).
Report is 3 commits behind head on main.

Files Patch % Lines
openrl/envs/crafter/crafter.py 0.00% 28 Missing ⚠️
openrl/envs/crafter/__init__.py 0.00% 10 Missing ⚠️
openrl/envs/common/registration.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   74.33%   74.11%   -0.23%     
==========================================
  Files         254      256       +2     
  Lines       13213    13254      +41     
==========================================
+ Hits         9822     9823       +1     
- Misses       3391     3431      +40     
Flag Coverage Δ
unittests 74.11% <4.76%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huangshiyu13 huangshiyu13 merged commit bc1575b into OpenRL-Lab:main Mar 22, 2024
3 of 5 checks passed
@huangshiyu13 huangshiyu13 mentioned this pull request Mar 22, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants