Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: editor: Backspace behavior is strange #3906

Closed
Tguisnet opened this issue Apr 14, 2023 · 1 comment
Closed

front: editor: Backspace behavior is strange #3906

Tguisnet opened this issue Apr 14, 2023 · 1 comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:minor Minor severity bug

Comments

@Tguisnet
Copy link
Contributor

What happened?

When we create a speed section, using backspac on our keyboard when giving a speed limit value change the value of the speed limit. (It looks like each time, it multiplied it by 3,6)

First Value :
image

After one backspace :
image

After two backspace :
image

What did you expect to happen?

We should be able to pop the value, or at least to do nothing.

How can we reproduce it (as minimally and precisely as possible)?

  1. Go on the editor
  2. press the backspace key when giving a speed limit value

What operating system, browser and environment are you using?

  • Browser: Chrome v110
  • OS: Windows 10
  • Env: Dgex Dev

OSRD version (top right corner Account button > Informations)

1d67312
@Tguisnet Tguisnet added kind:bug Something isn't working severity:minor Minor severity bug labels Apr 14, 2023
jacomyal added a commit that referenced this issue Apr 14, 2023
@jacomyal
editor: fixes #3904 and #3906
2b63c6d 
Details:
- Writes a new component dedicated to handle speed editions in km/h,
while the value is stored as m/s
- Handles weird behaviours by only updating the local component state
when the related number m/s value changes
- Uses this new component for both speed_limit and speed_limit_by_tag
edition
sim51 pushed a commit that referenced this issue Apr 14, 2023
@jacomyal @sim51
editor: fixes #3904 and #3906
7263f78 
Details:
- Writes a new component dedicated to handle speed editions in km/h,
while the value is stored as m/s
- Handles weird behaviours by only updating the local component state
when the related number m/s value changes
- Uses this new component for both speed_limit and speed_limit_by_tag
edition
@Castavo Castavo added the area:front Work on Standard OSRD Interface modules label May 12, 2023
@Tguisnet
Copy link
Contributor Author

Tguisnet commented Sep 6, 2023

I think this is solved.

@Tguisnet Tguisnet closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:minor Minor severity bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tguisnet @Castavo