Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize comfort types #8254

Closed
4 tasks
SharglutDev opened this issue Jul 30, 2024 · 0 comments · Fixed by #8525
Closed
4 tasks

Harmonize comfort types #8254

SharglutDev opened this issue Jul 30, 2024 · 0 comments · Fixed by #8525
Assignees
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Jul 30, 2024

Description and goal

With Trainschedule v2 model, we now use the type Comfort to define the comfort of a train in stdcmV2 and trainscheduleV2 (TrainScheduleBase type) endpoints.

The old model was using type RollingStockComfortType. Most of it will be removed when dropping v1 model.

But in rollingstock endpoints, we keep using this old type for effort curves and it should be harmonized with the new model.

Acceptance criteria

  • Type RollingStockComfortType is removed from the code base
  • All references of 'AC' instead of 'AIR_CONDITIONING'should be removed (including trads)
  • Type Comfort is now used for all rolling stock endpoints
  • Type TrainScheduleBase use Comfort for its comfort property
@SharglutDev SharglutDev added kind:enhancement Improvement of existing features area:editoast Work on Editoast Service labels Jul 30, 2024
@SharglutDev SharglutDev added the area:front Work on Standard OSRD Interface modules label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants