Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: harmonize comfort type #8525

Merged
merged 5 commits into from
Sep 3, 2024
Merged

editoast: harmonize comfort type #8525

merged 5 commits into from
Sep 3, 2024

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Aug 21, 2024 •
edited
Loading

Close #8254
Close #8371

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.82%. Comparing base (931e582) to head (1d1fac4).
Report is 54 commits behind head on dev.

Files with missing lines Patch % Lines
...ules/rollingStock/components/RollingStockCurve.tsx 12.50% 7 Missing ⚠️
...ponents/RollingStockEditor/CurveParamSelectors.tsx 37.50% 5 Missing ⚠️
...k/components/RollingStockCard/RollingStockCard.tsx 0.00% 2 Missing ⚠️
...nents/RollingStockCard/RollingStockCardButtons.tsx 0.00% 2 Missing ⚠️
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 33.33% 2 Missing ⚠️
...ollingStockEditor/RollingStockInformationPanel.tsx 0.00% 2 Missing ⚠️
front/src/stories/RollingStockSelector.stories.tsx 0.00% 2 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 75.00% 1 Missing ⚠️
front/src/modules/rollingStock/helpers/curves.ts 50.00% 1 Missing ⚠️
...modules/rollingStock/helpers/rollingStockEditor.ts 50.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8525      +/-   ##
============================================
- Coverage     36.85%   36.82%   -0.03%     
- Complexity     2177     2213      +36     
============================================
  Files          1254     1255       +1     
  Lines        113631   113801     +170     
  Branches       3202     3185      -17     
============================================
+ Hits          41881    41912      +31     
- Misses        69856    69997     +141     
+ Partials       1894     1892       -2
Flag Coverage Δ
core 74.75% <100.00%> (-0.05%) ⬇️
editoast 71.72% <ø> (-0.04%) ⬇️
front 14.92% <40.90%> (-0.04%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 7c70671 to 808e450 Compare August 21, 2024 21:21
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 20adb70 to 873f7e1 Compare August 22, 2024 22:35
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 2 times, most recently from 0f89754 to 761ed1d Compare August 29, 2024 13:03
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 4 times, most recently from dc55996 to f7b9ae4 Compare August 29, 2024 14:53
Base automatically changed from yci/delete-tsv1-endpoint to dev August 29, 2024 15:40
@younesschrifi younesschrifi marked this pull request as ready for review August 29, 2024 15:44
@younesschrifi younesschrifi requested review from a team as code owners August 29, 2024 15:44
SharglutDev
SharglutDev requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! Left comments, we need to test carefully to see if we missed something.

front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
front/src/modules/rollingStock/components/RollingStockCard/RollingStockCard.tsx Outdated Show resolved Hide resolved
front/src/modules/rollingStock/components/RollingStockCurve.tsx Outdated Show resolved Hide resolved
front/src/modules/rollingStock/components/RollingStockCurve.tsx Outdated Show resolved Hide resolved
front/src/modules/rollingStock/components/RollingStockCurve.tsx Outdated Show resolved Hide resolved
front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
front/src/common/api/generatedEditoastApi.ts Outdated Show resolved Hide resolved
@younesschrifi younesschrifi requested a review from a team as a code owner August 30, 2024 08:22
@younesschrifi younesschrifi requested a review from a team as a code owner August 30, 2024 08:24
shenriotpro
shenriotpro approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

woshilapin
woshilapin approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up and homogenization. Thank you.

flomonster
flomonster approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi self-assigned this Sep 2, 2024
Erashin
Erashin approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ :)

@younesschrifi younesschrifi force-pushed the yci/harmonize_comfort_type branch 2 times, most recently from 5279a26 to ebd3b0d Compare September 3, 2024 07:38
SharglutDev
SharglutDev approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, thank you for this PR !

@younesschrifi younesschrifi added this pull request to the merge queue Sep 3, 2024
Merged via the queue into dev with commit 53bd1e9 Sep 3, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/harmonize_comfort_type branch September 3, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@woshilapin woshilapin woshilapin approved these changes

@Erashin Erashin Erashin approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

@shenriotpro shenriotpro shenriotpro approved these changes

@eckter eckter Awaiting requested review from eckter eckter is a code owner automatically assigned from OpenRailAssociation/osrd-core

Assignees

@younesschrifi younesschrifi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create new RS with Air conditionning curves Harmonize comfort types
7 participants
@younesschrifi @codecov-commenter @woshilapin @flomonster @Erashin @SharglutDev @shenriotpro