Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: implement the block checks by signaling systems and drivers #2708

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Dec 23, 2022

Have the signaling system and signal drivers check the block according to the business rules.

@Khoyo Khoyo force-pushed the signaling-sim-block-checking branch from 6d6ae58 to 9f4e166 Compare December 23, 2022 13:10
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #2708 (afbed56) into dev (dd78e42) will decrease coverage by 30.37%.
The diff coverage is n/a.

❗ Current head afbed56 differs from pull request most recent head 068ea86. Consider uploading reports for the commit 068ea86 to get more accurate results

@@              Coverage Diff              @@
##                dev    #2708       +/-   ##
=============================================
- Coverage     68.13%   37.77%   -30.37%     
+ Complexity     1919     1679      -240     
=============================================
  Files           424      578      +154     
  Lines         21352    17719     -3633     
  Branches       1558     2461      +903     
=============================================
- Hits          14549     6693     -7856     
- Misses         6070    10640     +4570     
+ Partials        733      386      -347     
Flag Coverage Δ
core 83.77% <ø> (+4.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 709 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Khoyo Khoyo force-pushed the signaling-sim-block-checking branch from 9f4e166 to 1a5e4d6 Compare December 26, 2022 09:08
@Khoyo Khoyo force-pushed the signaling-sim-block-checking branch from afbed56 to d789213 Compare January 27, 2023 03:05
Co-Authored-By: Victor "multun" Collod <victor.collod@epita.fr>
Co-Authored-By: Younes "Khoyo" Khoudli <younes.khoudli@epita.fr>
@multun multun force-pushed the signaling-sim-block-checking branch from d789213 to 068ea86 Compare March 24, 2023 14:30
@Khoyo Khoyo marked this pull request as ready for review March 24, 2023 14:31
@Khoyo Khoyo requested a review from a team as a code owner March 24, 2023 14:31
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) I didn't understand everything (I should spend more time in core), but it looks good to me

@Khoyo Khoyo merged commit 1d5370c into dev Mar 24, 2023
@Khoyo Khoyo deleted the signaling-sim-block-checking branch March 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants