Refactor railjson track ranges classes in core #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2754 +/- ##
=========================================
Coverage 38.06% 38.06%
Complexity 1679 1679
=========================================
Files 576 576
Lines 17748 17748
Branches 2446 2446
=========================================
Hits 6756 6756
Misses 10607 10607
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Castavo
force-pushed
the
bpt/refactor-core-rjs-track-ranges
branch
from
4567251
to
e1fab7f
Compare
bloussou
reviewed
Jan 4, 2023
core/osrd-railjson/src/main/java/fr/sncf/osrd/railjson/schema/infra/trackranges/RJSRange.java
Outdated
Show resolved
Hide resolved
core/osrd-railjson/src/main/java/fr/sncf/osrd/railjson/schema/infra/trackranges/RJSRange.java
Outdated
Show resolved
Hide resolved
multun
suggested changes
Jan 4, 2023
core/osrd-railjson/src/main/java/fr/sncf/osrd/railjson/schema/infra/trackranges/RJSRange.java
Outdated
Show resolved
Hide resolved
multun
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things were a bit odd, some were no longer used.
I needed the name
RJSTrackRangeto be available for an actual track range (with a track reference in it) so I renamed the former class toRJSRangeand propagated the changes.