Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix endpoint that retrieve infra errors #2788

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

flomonster
Copy link
Contributor

A diesel error occurred when there was no geometry of the error.

A diesel error occurred when there was no geometry
of the error.
@flomonster flomonster requested a review from a team as a code owner January 7, 2023 13:31
@flomonster flomonster enabled auto-merge (rebase) January 7, 2023 13:31
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #2788 (95a28f4) into dev (f6c9ef4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #2788   +/-   ##
=========================================
  Coverage     38.06%   38.07%           
  Complexity     1679     1679           
=========================================
  Files           576      576           
  Lines         17748    17748           
  Branches       2446     2446           
=========================================
+ Hits           6756     6757    +1     
+ Misses        10607    10606    -1     
  Partials        385      385           
Flag Coverage Δ
editoast 73.23% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/infra/errors.rs 65.21% <ø> (ø)
editoast/src/chartos/bounding_box.rs 17.59% <0.00%> (+0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@multun multun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are front-end people ok with not always having a geometry?

@flomonster
Copy link
Contributor Author

@multun Yes they're aware of that some errors make the calculation of the geometry impossible. In practice if you modify an infra using the editor it shouldn't happen.

@flomonster flomonster merged commit 206e37c into dev Jan 9, 2023
@flomonster flomonster deleted the fam/fix-editoast-get-infra-errors branch January 9, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants