Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: useful type aliases #2799

Merged
merged 2 commits into from
Jan 9, 2023
Merged

front: useful type aliases #2799

merged 2 commits into from
Jan 9, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 9, 2023

To avoid having to give their params all the time :

ConsolidatedMergeDataPoint = MergedDataPoint<Date | null>
ConsolidatedPosition = Position<Date | null>
ConsolidatePositionSpeed = PositionSpeed<Date | null>
ConsolidatedRouteAspect = RouteAspect<Date | null, string>
ConsolidatedSignalAspect = SignalAspect<Date | null, string>

@anisometropie anisometropie requested a review from a team as a code owner January 9, 2023 11:29
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #2799 (3151f2c) into dev (206e37c) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #2799   +/-   ##
=========================================
  Coverage     38.07%   38.07%           
  Complexity     1679     1679           
=========================================
  Files           576      576           
  Lines         17744    17744           
  Branches       2446     2446           
=========================================
  Hits           6756     6756           
  Misses        10603    10603           
  Partials        385      385           
Flag Coverage Δ
front 4.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plications/osrd/components/Helpers/ChartHelpers.ts 9.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anisometropie anisometropie changed the title useful type aliases front: useful type aliases Jan 9, 2023
@alexandredamiron alexandredamiron merged commit b897f44 into dev Jan 9, 2023
@alexandredamiron alexandredamiron deleted the vcs/useful-type-aliases branch January 9, 2023 14:38
alexandredamiron pushed a commit that referenced this pull request Jan 9, 2023
To avoid having to give their params all the time :

```
ConsolidatedMergeDataPoint = MergedDataPoint<Date | null>
ConsolidatedPosition = Position<Date | null>
ConsolidatePositionSpeed = PositionSpeed<Date | null>
ConsolidatedRouteAspect = RouteAspect<Date | null, string>
ConsolidatedSignalAspect = SignalAspect<Date | null, string>
```
sim51 pushed a commit that referenced this pull request Jan 10, 2023
To avoid having to give their params all the time :

```
ConsolidatedMergeDataPoint = MergedDataPoint<Date | null>
ConsolidatedPosition = Position<Date | null>
ConsolidatePositionSpeed = PositionSpeed<Date | null>
ConsolidatedRouteAspect = RouteAspect<Date | null, string>
ConsolidatedSignalAspect = SignalAspect<Date | null, string>
```
alexandredamiron pushed a commit that referenced this pull request Jan 17, 2023
To avoid having to give their params all the time :

```
ConsolidatedMergeDataPoint = MergedDataPoint<Date | null>
ConsolidatedPosition = Position<Date | null>
ConsolidatePositionSpeed = PositionSpeed<Date | null>
ConsolidatedRouteAspect = RouteAspect<Date | null, string>
ConsolidatedSignalAspect = SignalAspect<Date | null, string>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants