Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: uses editoast instead of api #2838

Merged
merged 1 commit into from
Jan 10, 2023
Merged

core: uses editoast instead of api #2838

merged 1 commit into from
Jan 10, 2023

Conversation

flomonster
Copy link
Contributor

Since the endpoint to download an infra railjson is deprecated in API. Core should now use editoast.

@flomonster flomonster requested a review from a team as a code owner January 10, 2023 17:52
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #2838 (e6f14d9) into dev (cd22124) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #2838      +/-   ##
============================================
+ Coverage     37.88%   37.93%   +0.04%     
  Complexity     1693     1693              
============================================
  Files           583      582       -1     
  Lines         17865    17843      -22     
  Branches       2471     2466       -5     
============================================
  Hits           6768     6768              
+ Misses        10700    10678      -22     
  Partials        397      397              
Flag Coverage Δ
core 83.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/reducers/map.ts 20.43% <0.00%> (ø)
front/src/reducers/editor.ts 21.95% <0.00%> (ø)
front/src/applications/editor/Map.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% <0.00%> (ø)
front/src/applications/editor/tools/types.ts 100.00% <0.00%> (ø)
...src/applications/editor/components/EntitySumUp.tsx 0.00% <0.00%> (ø)
...src/applications/editor/components/LayersModal.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/Errors.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@multun
Copy link
Contributor

multun commented Jan 10, 2023

This should be followed up by removing the endpoint in API

@multun multun merged commit 3335203 into dev Jan 10, 2023
@multun multun deleted the fam/core-use-editoast branch January 10, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants