Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Pathfinding module #2854

Merged
merged 55 commits into from
Jan 27, 2023
Merged

front: Pathfinding module #2854

merged 55 commits into from
Jan 27, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 11, 2023

closes #2699

@anisometropie anisometropie requested a review from a team as a code owner January 11, 2023 15:57
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #2854 (df7a702) into dev (f605724) will increase coverage by 0.24%.
The diff coverage is 29.45%.

@@             Coverage Diff              @@
##                dev    #2854      +/-   ##
============================================
+ Coverage     38.83%   39.07%   +0.24%     
  Complexity     1704     1704              
============================================
  Files           600      605       +5     
  Lines         18392    18472      +80     
  Branches       2479     2490      +11     
============================================
+ Hits           7142     7218      +76     
- Misses        10842    10845       +3     
- Partials        408      409       +1     
Flag Coverage Δ
front 4.85% <29.45%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tudies/components/ManageTrainSchedule/Itinerary.js 0.00% <ø> (ø)
...rainSchedule/Itinerary/DisplayItinerary/Origin.tsx 0.00% <ø> (ø)
...TrainSchedule/Itinerary/DisplayItinerary/index.tsx 0.00% <0.00%> (ø)
...ManageTrainSchedule/Itinerary/ModalSuggeredVias.js 0.00% <0.00%> (ø)
...chedule/ManageTrainScheduleMap/RenderItinerary.tsx 0.00% <0.00%> (ø)
...ront/src/applications/operationalStudies/consts.ts 100.00% <ø> (ø)
front/src/common/api/osrdChartosApi.ts 0.00% <ø> (ø)
front/src/common/api/osrdEditoastApi.ts 0.00% <0.00%> (ø)
front/src/common/api/osrdMiddlewareApi.ts 5.88% <ø> (+5.88%) ⬆️
front/src/config/openapi-chartos-config.ts 0.00% <ø> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anisometropie anisometropie force-pushed the vcs/pathfinding-module branch 2 times, most recently from 5efef35 to 3cbdaba Compare January 16, 2023 20:59
@anisometropie anisometropie requested a review from a team as a code owner January 16, 2023 20:59
@anisometropie anisometropie changed the title front: Vcs/pathfinding module front: Pathfinding module Jan 25, 2023
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very important : keep modal access with JSON from pathfinding

front/src/common/Pathfinding/pathfinding.scss Outdated Show resolved Hide resolved
front/src/common/Pathfinding/pathfinding.scss Outdated Show resolved Hide resolved
front/src/common/Pathfinding/pathfinding.scss Outdated Show resolved Hide resolved
front/src/common/Pathfinding/pathfinding.scss Outdated Show resolved Hide resolved
front/src/common/Pathfinding/pathfinding.scss Outdated Show resolved Hide resolved
front/src/styles/scss/_variables.scss Outdated Show resolved Hide resolved
front/src/common/Pathfinding/Pathfinding.tsx Outdated Show resolved Hide resolved
front/src/styles/scss/common/pathfinding.scss Outdated Show resolved Hide resolved
front/src/styles/scss/common/pathfinding.scss Outdated Show resolved Hide resolved
front/src/styles/scss/common/pathfinding.scss Outdated Show resolved Hide resolved
front/src/styles/scss/common/pathfinding.scss Outdated Show resolved Hide resolved
front/src/styles/scss/common/pathfinding.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@alexandredamiron alexandredamiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in ./.storybook/preview.js, can you update the import paths ? It cause storybook build crash and will make the CI fail.

nicolaswurtz
nicolaswurtz previously approved these changes Jan 26, 2023
flomonster
flomonster previously approved these changes Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: pathfinding: Status module proposal to concentrate all about pathfinding & UX guidelines
4 participants