core: stdcm: standard allowance bugfixes #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eckter
commented
Jan 12, 2023
•
eckter
commented
- Handle exceptions that happen inside the binary search, when we can handle them
- Use the given standard allowance to consider the fastest run time
- Remove an assert that could be triggered in linear allowances
eckter
force-pushed
the
ech/fix-stdcm-allowance
branch
from
397fc7e
to
b2ba06b
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2866 +/- ##
============================================
+ Coverage 38.00% 38.03% +0.02%
+ Complexity 1699 1698 -1
============================================
Files 585 585
Lines 17969 17987 +18
Branches 2475 2478 +3
============================================
+ Hits 6829 6841 +12
- Misses 10742 10746 +4
- Partials 398 400 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
In some cases we can't even build a valid envelope during the binary search, but the error is only caused by input values. We can catch these errors to continue the search. This commit also contains a new STDCM test that reproduces the case
eckter
force-pushed
the
ech/fix-stdcm-allowance
branch
from
b2ba06b
to
833ff30
Compare
multun
approved these changes
Jan 13, 2023
axrolld
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.