editoast: add custom implem of cors #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
force-pushed
the
fam/add-editoast-cors
branch
from
99a4f75
to
4696b83
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2879 +/- ##
=========================================
Coverage 38.06% 38.07%
Complexity 1701 1701
=========================================
Files 585 586 +1
Lines 18010 18020 +10
Branches 2486 2486
=========================================
+ Hits 6856 6861 +5
- Misses 10755 10760 +5
Partials 399 399
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
multun
reviewed
Jan 13, 2023
Comment on lines
+22
to
+23
| response.set_header(Header::new("Access-Control-Allow-Headers", "*")); | ||
| response.set_header(Header::new("Access-Control-Allow-Origin", "*")); |
There was a problem hiding this comment.
that's not great, can't we have an option to restrict CORS a bit? We can leave it as is for now, but I'd very much like to have a TODO-list of web app hardening things to do
flomonster
force-pushed
the
fam/add-editoast-cors
branch
from
4696b83
to
98d8f15
Compare
flomonster
force-pushed
the
fam/add-editoast-cors
branch
from
98d8f15
to
4869fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.