Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Fix All signals button in Map Settings #2910

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Jan 16, 2023

close #2835

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner January 16, 2023 18:20
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #2910 (2604cd1) into dev (88613d0) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #2910      +/-   ##
============================================
- Coverage     38.31%   38.27%   -0.04%     
  Complexity     1708     1708              
============================================
  Files           593      593              
  Lines         18104    18120      +16     
  Branches       2503     2505       +2     
============================================
  Hits           6936     6936              
- Misses        10764    10780      +16     
  Partials        404      404              
Flag Coverage Δ
front 4.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ront/src/common/Map/Settings/MapSettingsSignals.js 0.00% <0.00%> (ø)
...components/Simulation/SpeedSpaceChart/d3Helpers.js 0.00% <0.00%> (ø)
...ents/Simulation/SpeedSpaceChart/SpeedSpaceChart.js 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anisometropie anisometropie merged commit a850451 into dev Jan 17, 2023
@anisometropie anisometropie deleted the usn/fix-all-signals-button branch January 17, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"All signals" display button isn't working
2 participants