Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: Add mvt_view_metadata() route to editoast #2912

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

bloussou
Copy link
Contributor

This PR is :

  • adding /layers/layer/{layer_slug}/mvt/{view_slug}/ route to editoast
  • adding max_zoom field to map_layers.yml

close #2890

@bloussou bloussou added the area:editoast Work on Editoast Service label Jan 17, 2023
@bloussou bloussou requested a review from a team as a code owner January 17, 2023 09:39
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #2912 (e74485e) into dev (12ec135) will increase coverage by 0.05%.
The diff coverage is 83.33%.

❗ Current head e74485e differs from pull request most recent head e7e6cf6. Consider uploading reports for the commit e7e6cf6 to get more accurate results

@@             Coverage Diff              @@
##                dev    #2912      +/-   ##
============================================
+ Coverage     38.07%   38.13%   +0.05%     
  Complexity     1713     1713              
============================================
  Files           598      599       +1     
  Lines         18207    18229      +22     
  Branches       2513     2513              
============================================
+ Hits           6933     6951      +18     
- Misses        10868    10872       +4     
  Partials        406      406              
Flag Coverage Δ
editoast 73.37% <83.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/chartos/map_layers.rs 100.00% <ø> (ø)
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/views/layers/layer.rs 78.94% <78.94%> (ø)
editoast/src/main.rs 35.48% <100.00%> (+2.15%) ⬆️
editoast/src/views/layers/mod.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
@bloussou bloussou force-pushed the brieuc/MvtViewMetadata branch 2 times, most recently from 8b5144a to 693e189 Compare January 17, 2023 10:35
editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/api_error.rs Outdated Show resolved Hide resolved
editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/api_error.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/api_error.rs Outdated Show resolved Hide resolved
@bloussou bloussou force-pushed the brieuc/MvtViewMetadata branch 2 times, most recently from f2a3b9c to ee04b9c Compare January 18, 2023 13:54
@bloussou
Copy link
Contributor Author

bloussou commented Jan 18, 2023

Last commit e74485e is a suggestion to avoid unpredictable order in response : https://github.com/DGEXSolutions/osrd/actions/runs/3949537955/jobs/6760877075#step:10:405

The suggestion was taken from rust-lang/rfcs#2731

I can revert it and find another way if you are not ok with this

editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
editoast/src/views/layers/layer.rs Outdated Show resolved Hide resolved
@flomonster flomonster merged commit 7ff3fb1 into dev Jan 18, 2023
@flomonster flomonster deleted the brieuc/MvtViewMetadata branch January 18, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mvt_view_metadata() route to editoast
3 participants