Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editoast: Invalidate cache without chartos #2953

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

bloussou
Copy link
Contributor

This pr is :

  • Invalidating cache using rust redis client
  • Removing reqwest dependency
  • Removing the need to connect to chartos from editoast

close #2894

@bloussou bloussou added the area:editoast Work on Editoast Service label Jan 19, 2023
@bloussou bloussou requested a review from a team as a code owner January 19, 2023 15:53
@bloussou bloussou force-pushed the brieuc/InvalidateFromEditoast branch 2 times, most recently from 6ca9d5c to 5ed98de Compare January 19, 2023 16:30
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #2953 (0dcc802) into dev (2ebb72d) will increase coverage by 0.04%.
The diff coverage is 51.94%.

@@             Coverage Diff              @@
##                dev    #2953      +/-   ##
============================================
+ Coverage     38.28%   38.33%   +0.04%     
  Complexity     1713     1713              
============================================
  Files           600      600              
  Lines         18342    18381      +39     
  Branches       2513     2513              
============================================
+ Hits           7022     7046      +24     
- Misses        10914    10929      +15     
  Partials        406      406              
Flag Coverage Δ
editoast 72.86% <51.94%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/main.rs 31.25% <0.00%> (-2.82%) ⬇️
editoast/src/views/mod.rs 95.00% <ø> (ø)
editoast/src/chartos/mod.rs 31.42% <31.42%> (-18.58%) ⬇️
editoast/src/chartos/layer_cache.rs 100.00% <100.00%> (ø)
editoast/src/chartos/redis_utils.rs 100.00% <100.00%> (ø)
editoast/src/views/infra/edition.rs 96.87% <100.00%> (+0.57%) ⬆️
editoast/src/views/infra/mod.rs 98.24% <100.00%> (+0.04%) ⬆️
editoast/src/chartos/bounding_box.rs 19.38% <0.00%> (+1.02%) ⬆️
editoast/src/generated_data/utils.rs 84.21% <0.00%> (+5.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR !

Can you adapt the docker-compose files and CI. Since editoast doesn't need chartos to work but redis we can simplify things.

editoast/src/chartos/layer_cache.rs Show resolved Hide resolved
editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/edition.rs Show resolved Hide resolved
editoast/src/chartos/mod.rs Outdated Show resolved Hide resolved
@bloussou bloussou mentioned this pull request Jan 20, 2023
1 task
@bloussou bloussou force-pushed the brieuc/InvalidateFromEditoast branch from 5ed98de to c2f5748 Compare January 20, 2023 09:07
@bloussou bloussou requested a review from multun as a code owner January 20, 2023 09:07
@bloussou bloussou force-pushed the brieuc/InvalidateFromEditoast branch 2 times, most recently from 5dd4ce6 to d908b81 Compare January 20, 2023 11:31
flomonster
flomonster previously approved these changes Jan 20, 2023
@bloussou bloussou merged commit d88a445 into dev Jan 20, 2023
@bloussou bloussou deleted the brieuc/InvalidateFromEditoast branch January 20, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidate layers from editoast using redis connection and remove reqwest dependency
2 participants