Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adn/proper gev/get isolation #3012

Merged
merged 12 commits into from
Jan 31, 2023
Merged

Adn/proper gev/get isolation #3012

merged 12 commits into from
Jan 31, 2023

Conversation

alexandredamiron
Copy link
Contributor

@alexandredamiron alexandredamiron commented Jan 26, 2023

closes #2447
closes #2565
GET and GEV are now Isolated with same feature and used in Simulation Results. Tests them on simulation Results and StoryBook. No need to redraw triggers update even some cleanup can still be done (once curvesslopes will be isolated too)

@alexandredamiron alexandredamiron requested a review from a team as a code owner January 26, 2023 19:30
@alexandredamiron alexandredamiron changed the title Adn/proper gev isolation Adn/proper gev/get isolation Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #3012 (3ca806f) into dev (c1c3796) will decrease coverage by 0.56%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3012      +/-   ##
============================================
- Coverage     38.99%   38.44%   -0.56%     
- Complexity     1705     1713       +8     
============================================
  Files           606      598       -8     
  Lines         18528    18524       -4     
  Branches       2497     2513      +16     
============================================
- Hits           7225     7121     -104     
- Misses        10893    10996     +103     
+ Partials        410      407       -3     
Flag Coverage Δ
front 4.75% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Studies/components/Scenario/TimetableTrainCard.tsx 0.00% <ø> (ø)
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 8.95% <0.00%> (-0.14%) ⬇️
...ulationResults/ChartHelpers/enableInteractivity.js 0.00% <0.00%> (ø)
...ponents/SimulationResults/ChartModal/ChartModal.js 0.00% <0.00%> (ø)
...ies/components/SimulationResults/SpaceTimeChart.js 0.00% <ø> (ø)
...SimulationResults/SpaceTimeChart/SpaceTimeChart.js 0.00% <0.00%> (ø)
...ts/SimulationResults/SpaceTimeChart/createChart.ts 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/d3Helpers.js 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/drawTrain.js 0.00% <ø> (ø)
...s/SimulationResults/SpaceTimeChart/withOSRDData.js 0.00% <0.00%> (ø)
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anisometropie
anisometropie previously approved these changes Jan 31, 2023
@clarani clarani enabled auto-merge (rebase) January 31, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants