Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: api: minor fixes on rolling stock selector #3052

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 31, 2023

close #3047

  • load the rollingStock image before the render
  • remove transform in RollingStock image css
  • rolling stocks cards should not be transparent if no rs is selected

@clarani clarani requested a review from a team as a code owner January 31, 2023 16:46
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #3052 (95e6214) into dev (8a588f5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3052      +/-   ##
============================================
+ Coverage     38.66%   38.69%   +0.03%     
  Complexity     1708     1708              
============================================
  Files           605      605              
  Lines         18770    18765       -5     
  Branches       2516     2516              
============================================
+ Hits           7258     7262       +4     
+ Misses        11103    11095       -8     
+ Partials        409      408       -1     
Flag Coverage Δ
front 4.79% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/src/applications/customget/views/TrainDetails.js 0.00% <ø> (ø)
front/src/applications/opendata/OpenDataImport.js 0.00% <0.00%> (ø)
...rc/applications/opendata/components/TrainDetail.js 0.00% <ø> (ø)
...nageTrainSchedule/Itinerary/ModalPathJSONDetail.js 0.00% <0.00%> (ø)
...omponents/ManageTrainSchedule/TimetableSelector.js 0.00% <0.00%> (ø)
...tionResults/Allowances/StandardAllowanceDefault.js 0.00% <ø> (ø)
...ents/SimulationResults/Allowances/withOSRDData.tsx 0.00% <ø> (ø)
...onents/TimetableSelector/TimetableSelectorModal.js 0.00% <0.00%> (ø)
front/src/applications/stdcm/getStdcmTimetable.js 0.00% <ø> (ø)
.../src/applications/stdcm/views/StdcmRequestModal.js 0.00% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz marked this pull request as draft February 2, 2023 10:55
@clarani clarani force-pushed the cni/front-fix-rs-selector branch 3 times, most recently from 6d7c16b to 7d31fd5 Compare February 2, 2023 11:27
@clarani clarani marked this pull request as ready for review February 2, 2023 12:53
@clarani clarani requested a review from a team as a code owner February 3, 2023 10:56
@clarani clarani changed the title front: minor fixes on rolling stock selector front: api: minor fixes on rolling stock selector Feb 3, 2023
load the image outside the <img /> because of authentication + improve get method (common/requests.ts)
- remove transform in RollingStock image css
- rolling stocks cards should not be transparent if no rs is selected
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for api

@nicolaswurtz nicolaswurtz merged commit 1a3b6fe into dev Feb 3, 2023
@nicolaswurtz nicolaswurtz deleted the cni/front-fix-rs-selector branch February 3, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: minor issues about rollingstock selector
3 participants