Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cni/fix space time chart #3112

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Cni/fix space time chart #3112

merged 1 commit into from
Feb 7, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 6, 2023 •
edited

fixes #3100, fixes #3019

  • in storybook, we can now select a train on click (run yarn storybook to launch storybook)
  • fix the following issue : drag and drop 1 train affects all the trains
  • fix the following issue : select a train AND drag and drop it, the train jumps in time

@clarani clarani requested a review from a team as a code owner February 6, 2023 15:41
@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited

Codecov Report

Merging #3112 (7238b85) into dev (7bd2d6b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #3112   +/-   ##
=========================================
  Coverage     38.66%   38.66%           
  Complexity     1707     1707           
=========================================
  Files           602      602           
  Lines         18745    18744    -1     
  Branches       2516     2514    -2     
=========================================
  Hits           7247     7247           
+ Misses        11090    11089    -1     
  Partials        408      408
Flag Coverage Δ
front 4.79% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ies/components/SimulationResults/SpaceTimeChart.js 0.00% <0.00%> (ø)
...SimulationResults/SpaceTimeChart/SpaceTimeChart.js 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/d3Helpers.js 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/drawTrain.js 0.00% <0.00%> (ø)
...s/SimulationResults/SpaceTimeChart/withOSRDData.js 0.00% <ø> (ø)
...ons/operationalStudies/views/SimulationResults.tsx 0.00% <ø> (ø)
...common/ReleaseInformations/ReleaseInformations.tsx 0.00% <ø> (ø)
front/src/stories/SpaceTimeChart.stories.tsx 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani marked this pull request as draft February 7, 2023 14:38
@clarani
front: space-time-chart
7238b85 
- in storybook, we can now select a train on click
- fix drag and drop 1 train affects all the trains
- fix drag and drop 1 train on select (the train does not jump in time anymore)
@clarani clarani marked this pull request as ready for review February 7, 2023 14:48
@alexandredamiron alexandredamiron merged commit 804cc21 into dev Feb 7, 2023
@alexandredamiron alexandredamiron deleted the cni/fix-space-time-chart branch February 7, 2023 17:31
anisometropie pushed a commit that referenced this pull request Feb 8, 2023
@clarani @anisometropie
Cni/fix space time chart (#3112)
d573553 
fixes #3100, fixes #3019 

- in storybook, we can now select a train on click (run `yarn storybook`
to launch storybook)
- fix the following issue : drag and drop 1 train affects all the trains
- fix the following issue : select a train AND drag and drop it, the
train jumps in time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandredamiron alexandredamiron alexandredamiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clarani @alexandredamiron