Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix spinner #3118

Merged
merged 1 commit into from
Feb 8, 2023
Merged

front: fix spinner #3118

merged 1 commit into from
Feb 8, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 7, 2023

Closes #3095

@clarani clarani requested a review from a team as a code owner February 7, 2023 14:47
@clarani clarani marked this pull request as draft February 7, 2023 14:47
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3118 (c49323f) into dev (1912f36) will increase coverage by 0.06%.
The diff coverage is 25.00%.

❗ Current head c49323f differs from pull request most recent head 8a28431. Consider uploading reports for the commit 8a28431 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3118      +/-   ##
============================================
+ Coverage     38.67%   38.74%   +0.06%     
+ Complexity     1709     1707       -2     
============================================
  Files           603      604       +1     
  Lines         18749    18756       +7     
  Branches       2511     2514       +3     
============================================
+ Hits           7252     7267      +15     
+ Misses        11091    11081      -10     
- Partials        406      408       +2     
Flag Coverage Δ
front 4.86% <25.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/applications/editor/components/EntitySumUp.tsx 0.00% <0.00%> (ø)
.../editor/components/InfraErrors/InfraErrorsList.tsx 0.00% <ø> (ø)
...ications/editor/components/InfraSelectionModal.tsx 0.00% <ø> (ø)
...ManageTrainSchedule/Itinerary/ModalSuggeredVias.js 0.00% <0.00%> (ø)
.../src/applications/stdcm/views/StdcmRequestModal.js 0.00% <ø> (ø)
front/src/common/Pathfinding/Pathfinding.tsx 15.55% <ø> (ø)
front/src/common/Loader.js 40.00% <33.33%> (+40.00%) ⬆️
editoast/src/views/infra/railjson.rs 14.81% <0.00%> (-63.76%) ⬇️
...va/fr/sncf/osrd/train/StandaloneTrainSchedule.java 66.66% <0.00%> (-33.34%) ⬇️
editoast/src/schema/operation/mod.rs 26.66% <0.00%> (-25.72%) ⬇️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani marked this pull request as ready for review February 7, 2023 16:00
Math-R
Math-R previously approved these changes Feb 8, 2023
@clarani clarani merged commit 3bc309b into dev Feb 8, 2023
@clarani clarani deleted the cni/front-fix-spinner branch February 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: fix spinner
3 participants