Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vcs/electrical profile endpoint #3125

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Vcs/electrical profile endpoint #3125

merged 1 commit into from
Mar 8, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Feb 8, 2023 •
edited
Loading

closes #2891

@anisometropie anisometropie force-pushed the vcs/electrical-profile-endpoint branch 2 times, most recently from 9089f81 to 1c65a58 Compare February 8, 2023 19:29
@anisometropie anisometropie added the area:editoast Work on Editoast Service label Feb 9, 2023
@anisometropie anisometropie force-pushed the vcs/electrical-profile-endpoint branch 3 times, most recently from 3366952 to 0d1b87c Compare March 7, 2023 11:27
@anisometropie anisometropie marked this pull request as ready for review March 7, 2023 12:20
@anisometropie anisometropie requested a review from a team as a code owner March 7, 2023 12:20
@anisometropie anisometropie force-pushed the vcs/electrical-profile-endpoint branch from 0d1b87c to bbe0d40 Compare March 7, 2023 12:22
flomonster
flomonster requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Only a few things to adapt.

editoast/src/client/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/electrical_profiles.rs Outdated Show resolved Hide resolved
editoast/src/views/electrical_profiles.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #3125 (2873d68) into dev (15d6064) will decrease coverage by 0.03%.
The diff coverage is 58.06%.

❗ Current head 2873d68 differs from pull request most recent head b7f6565. Consider uploading reports for the commit b7f6565 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3125      +/-   ##
============================================
- Coverage     67.88%   67.85%   -0.03%     
  Complexity     1880     1880              
============================================
  Files           398      398              
  Lines         19737    19766      +29     
  Branches       1500     1500              
============================================
+ Hits          13398    13413      +15     
- Misses         5655     5669      +14     
  Partials        684      684
Flag Coverage Δ
editoast 73.92% <58.06%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/main.rs 6.92% <0.00%> (-0.71%) ⬇️
editoast/src/views/mod.rs 94.44% <ø> (ø)
editoast/src/views/electrical_profiles.rs 91.07% <94.73%> (+1.32%) ⬆️
editoast/src/map/bounding_box.rs 27.55% <0.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anisometropie anisometropie force-pushed the vcs/electrical-profile-endpoint branch from 2f55fbf to b1f1020 Compare March 7, 2023 21:51
flomonster
flomonster previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@anisometropie
editoast: electrical profile schema endpoint
b7f6565 
finally compiling

add command

review fixes

fix missing endpoint in HttpServiceFactory & use Query<> with a struct

add open api

block and connection are handled by ElectricalProfileSet::create_electrical_profile_set
@anisometropie anisometropie force-pushed the vcs/electrical-profile-endpoint branch from 2873d68 to b7f6565 Compare March 8, 2023 12:20
@flomonster flomonster merged commit d2274e9 into dev Mar 8, 2023
@flomonster flomonster deleted the vcs/electrical-profile-endpoint branch March 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an endpoint to post an electrical profile
2 participants
@anisometropie @flomonster