Refactor core to enforce isolation of envelope and envelope-sim code
#3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3129 +/- ##
============================================
+ Coverage 40.96% 43.25% +2.28%
- Complexity 1711 1874 +163
============================================
Files 630 708 +78
Lines 18731 20697 +1966
Branches 2344 2579 +235
============================================
+ Hits 7674 8953 +1279
- Misses 10643 11261 +618
- Partials 414 483 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Castavo
force-pushed
the
bpt/refactor-envelope-classes
branch
2 times, most recently
from
8271a42
to
71ce4f8
Compare
flomonster
previously approved these changes
Feb 16, 2023
core/envelope-sim/src/test/java/fr/sncf/osrd/envelope/MRSPEnvelopeBuilderTest.java
Outdated
Show resolved
Hide resolved
Castavo
changed the title
envelope and envelope-sim code
bloussou
reviewed
Feb 16, 2023
core/envelope-sim/src/test/java/fr/sncf/osrd/envelope/MRSPEnvelopeBuilderTest.java
Outdated
Show resolved
Hide resolved
added 6 commits
February 20, 2023 16:14
Castavo
force-pushed
the
bpt/refactor-envelope-classes
branch
from
7283291
to
94a8f62
Compare
multun
suggested changes
Feb 21, 2023
core/osrd-reporting/src/main/java/fr/sncf/osrd/reporting/Reflection.java
Show resolved
Hide resolved
younesschrifi
pushed a commit
that referenced
this pull request
Feb 27, 2023
closes #3086 - make `envelope` and `envelope-sim` gradle sub-projects, like `osrd-railjson` - rename `EnvelopePath` to `EnvelopeSimPath` to match`EnvelopeSimContext`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3086
This PR makes
envelopeandenvelope-simpackages a gradle sub-project (likeosrd-railjson) in order to better isolate this part of core.For that I had to make the package
reportingit's own sub-project too.P.S. I added an extra change (in this commit) to rename
EnvelopePathtoEnvelopeSimPath(to matchEnvelopeSimContext)