Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add operationalpoint search front #3143

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Feb 9, 2023

image

@Math-R Math-R requested a review from a team as a code owner February 9, 2023 17:24
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #3143 (c9060fc) into dev (4208172) will increase coverage by 2.23%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3143      +/-   ##
============================================
+ Coverage     38.19%   40.42%   +2.23%     
  Complexity     1709     1709              
============================================
  Files           625      629       +4     
  Lines         19873    18675    -1198     
  Branches       2604     2331     -273     
============================================
- Hits           7590     7549      -41     
+ Misses        11877    10723    -1154     
+ Partials        406      403       -3     
Flag Coverage Δ
front 4.81% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/Map/Layers/SearchMarker.tsx 0.00% <ø> (ø)
front/src/common/Map/Search/MapSearchStation.js 0.00% <0.00%> (ø)
front/src/keycloak/index.js 40.00% <0.00%> (-6.67%) ⬇️
front/src/reducers/user.ts 13.69% <0.00%> (ø)
front/src/common/requests.ts 0.00% <0.00%> (ø)
.../src/applications/stdcm/views/OSRDCStdcmConfig.tsx 0.00% <0.00%> (ø)
...src/applications/operationalStudies/views/Study.js 0.00% <0.00%> (ø)
...c/applications/operationalStudies/views/Project.js 0.00% <0.00%> (ø)
...operationalStudies/components/Home/ProjectCard.tsx 0.00% <0.00%> (ø)
...perationalStudies/components/Project/StudyCard.tsx 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Math-R Math-R force-pushed the mrd/search-front-2 branch 2 times, most recently from 1227e7a to f6d8a2a Compare February 9, 2023 18:07
bloussou
bloussou previously approved these changes Feb 10, 2023
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cool !!! Could be nice to add a screenshot to the description of the PR to help the reviewer and future us understand what has been done in this PR :)
image

leovalais
leovalais previously approved these changes Feb 10, 2023
clarani
clarani previously approved these changes Feb 10, 2023
@nicolaswurtz nicolaswurtz enabled auto-merge (rebase) February 10, 2023 14:15
@nicolaswurtz nicolaswurtz merged commit 45769db into dev Feb 10, 2023
@nicolaswurtz nicolaswurtz deleted the mrd/search-front-2 branch February 10, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants