Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix GEV for stdcm #3160

Merged
merged 1 commit into from
Feb 10, 2023
Merged

front: fix GEV for stdcm #3160

merged 1 commit into from
Feb 10, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 10, 2023

Closes #3153

STDCM is broken 😢
image

Thanks to this PR (fix GEV and remove margin on the left)
image

@clarani clarani marked this pull request as ready for review February 10, 2023 14:17
@clarani clarani requested a review from a team as a code owner February 10, 2023 14:17
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #3160 (e64582c) into dev (79b2dd3) will not change coverage.
The diff coverage is n/a.

❗ Current head e64582c differs from pull request most recent head 5b4b5ee. Consider uploading reports for the commit 5b4b5ee to get more accurate results

@@            Coverage Diff            @@
##                dev    #3160   +/-   ##
=========================================
  Coverage     40.62%   40.62%           
  Complexity     1709     1709           
=========================================
  Files           629      629           
  Lines         18704    18704           
  Branches       2328     2328           
=========================================
  Hits           7598     7598           
  Misses        10703    10703           
  Partials        403      403           
Flag Coverage Δ
front 4.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/src/applications/stdcm/views/OSRDStdcmResults.js 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani force-pushed the cni/fix-stdcm-demo branch 2 times, most recently from 7946365 to e64582c Compare February 10, 2023 14:23
@eckter eckter linked an issue Feb 10, 2023 that may be closed by this pull request
@nicolaswurtz nicolaswurtz merged commit cba1397 into dev Feb 10, 2023
@nicolaswurtz nicolaswurtz deleted the cni/fix-stdcm-demo branch February 10, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: stdcm: speed chart doesn't render properly
4 participants