Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: prevents a 0-length part in envelope overlay edge case #3190

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 16, 2023

Fixes #3189

@eckter eckter requested a review from a team as a code owner February 16, 2023 17:53
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #3190 (06897ac) into dev (3dbd563) will decrease coverage by 0.04%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##                dev    #3190      +/-   ##
============================================
- Coverage     40.36%   40.33%   -0.04%     
  Complexity     1711     1711              
============================================
  Files           630      630              
  Lines         18752    18766      +14     
  Branches       2342     2352      +10     
============================================
  Hits           7570     7570              
- Misses        10780    10782       +2     
- Partials        402      414      +12     
Flag Coverage Δ
core 83.76% <14.28%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../fr/sncf/osrd/envelope/OverlayEnvelopeBuilder.java 90.69% <0.00%> (-4.43%) ⬇️
.../java/fr/sncf/osrd/envelope/part/EnvelopePart.java 80.08% <16.66%> (-3.40%) ⬇️
...d/infra_state/implementation/TrainPathBuilder.java 81.94% <0.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eckter eckter merged commit 143409e into dev Feb 17, 2023
@eckter eckter deleted the ech/fix-envelope-cursor-edge-case branch February 17, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: envelope overlay sometimes cause 0-length envelope part
2 participants