Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Limit layers to be searched for SnappedMarker #3214

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

ttsirkia
Copy link
Contributor

This will limit the searching only for the track section layers when moving mouse over map and searching the coordinates for SnappedMarker.

Unless this causes some unwanted side-effects which I didn't notice, this should fix #2927, #3162 and #3150.

This will limit the searching only for the track section layers when moving mouse over map and searching the coordinates for `SnappedMarker`.

Unless this causes some unwanted side-effects which I didn't notice, this should fix OpenRailAssociation#2927, OpenRailAssociation#3162 and OpenRailAssociation#3150.
@ttsirkia ttsirkia requested a review from a team as a code owner February 19, 2023 16:33
@ttsirkia ttsirkia changed the title Limit layers to be searched for SnappedMarker front: Limit layers to be searched for SnappedMarker Feb 19, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #3214 (e80e822) into dev (a00fe81) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3214      +/-   ##
============================================
- Coverage     40.74%   40.74%   -0.01%     
  Complexity     1711     1711              
============================================
  Files           631      631              
  Lines         18826    18829       +3     
  Branches       2360     2360              
============================================
  Hits           7671     7671              
- Misses        10741    10744       +3     
  Partials        414      414              
Flag Coverage Δ
front 4.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onalStudies/components/ManageTrainSchedule/Map.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules labels Feb 20, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR ! Tested on my side, everything is working 👍

@anisometropie anisometropie merged commit 40b0af3 into OpenRailAssociation:dev Feb 20, 2023
@anisometropie
Copy link
Contributor

This does fix #2927 & #3150, cheers @ttsirkia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: linear data layers prevent placing points on tracks
3 participants