Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: isolate schemas in osrd_schemas package #3236

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Feb 20, 2023

This PR is moving schemas in a separate python package.

  • api code is now under python/api
  • api/osrd_infra/schemas/ -> python/osrd_schemas
  • `python folder as been created because of docker build context, IMO it is the simplest way to have something working : Support multiple build contexts docker/compose#9461
  • Added linter checks in ci for osrd_schemas package

close #1150

@bloussou bloussou self-assigned this Feb 20, 2023
@bloussou bloussou added the area:api (deprecated) Work on Api Service (deprecated) label Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #3236 (359ddca) into dev (eb5d4ea) will decrease coverage by 0.32%.
The diff coverage is n/a.

❗ Current head 359ddca differs from pull request most recent head bd496e8. Consider uploading reports for the commit bd496e8 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3236      +/-   ##
============================================
- Coverage     67.19%   66.87%   -0.32%     
  Complexity     1876     1876              
============================================
  Files           398      396       -2     
  Lines         19153    19106      -47     
  Branches       1498     1488      -10     
============================================
- Hits          12869    12777      -92     
- Misses         5598     5653      +55     
+ Partials        686      676      -10     
Flag Coverage Δ
core 79.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/utils/numbers.ts 38.88% <0.00%> (-33.34%) ⬇️
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 24.18% <0.00%> (-12.39%) ⬇️
...ts/SimulationResults/SpaceTimeChart/createTrain.ts 27.43% <0.00%> (-1.27%) ⬇️
front/src/reducers/osrdsimulation/index.ts 49.47% <0.00%> (-0.53%) ⬇️
editoast/src/views/mod.rs 94.11% <0.00%> (-0.33%) ⬇️
...ront/src/applications/operationalStudies/consts.ts 68.65% <0.00%> (-0.10%) ⬇️
front/src/common/api/osrdEditoastApi.ts 91.39% <0.00%> (-0.02%) ⬇️
editoast/src/main.rs 7.62% <0.00%> (ø)
...nents/SimulationResults/simulationResultsConsts.ts
editoast/src/views/documents.rs
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/IsolateSchemas branch 2 times, most recently from b31989e to 367d32f Compare March 1, 2023 09:16
@bloussou bloussou marked this pull request as ready for review March 1, 2023 09:16
@bloussou bloussou requested review from a team, flomonster and multun as code owners March 1, 2023 09:16
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

Few files should be updated:

  • .github/dependabot
  • .github/CODEOWNERS

@multun multun merged commit a04a66a into dev Mar 1, 2023
@multun multun deleted the brieuc/IsolateSchemas branch March 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api (deprecated) Work on Api Service (deprecated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate schemas
3 participants