Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add speed transition offset behaviour #3256

Merged
merged 9 commits into from
Mar 10, 2023
Merged

add speed transition offset behaviour #3256

merged 9 commits into from
Mar 10, 2023

Conversation

majaziri
Copy link
Contributor

No description provided.

@majaziri majaziri requested a review from a team as a code owner February 20, 2023 21:05
@multun multun marked this pull request as draft February 20, 2023 21:38
@majaziri majaziri linked an issue Feb 22, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3256 (40ccbd9) into dev (925db4a) will decrease coverage by 0.72%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##                dev    #3256      +/-   ##
============================================
- Coverage     67.89%   67.18%   -0.72%     
- Complexity     1880     1883       +3     
============================================
  Files           404      397       -7     
  Lines         20059    18760    -1299     
  Branches       1501     1490      -11     
============================================
- Hits          13620    12604    -1016     
+ Misses         5755     5482     -273     
+ Partials        684      674      -10     
Flag Coverage Δ
core 79.32% <94.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../fr/sncf/osrd/cli/StandaloneSimulationCommand.java 0.00% <0.00%> (ø)
...ava/fr/sncf/osrd/stdcm/graph/STDCMEdgeBuilder.java 98.68% <ø> (ø)
...ava/fr/sncf/osrd/stdcm/graph/STDCMSimulations.java 97.50% <ø> (ø)
...im/src/main/java/fr/sncf/osrd/DriverBehaviour.java 100.00% <100.00%> (ø)
...ava/fr/sncf/osrd/envelope/MRSPEnvelopeBuilder.java 91.48% <100.00%> (+0.37%) ⬆️
...fr/sncf/osrd/api/StandaloneSimulationEndpoint.java 93.93% <100.00%> (+0.09%) ⬆️
...ain/java/fr/sncf/osrd/api/stdcm/STDCMEndpoint.java 70.96% <100.00%> (+0.31%) ⬆️
...ain/java/fr/sncf/osrd/envelope_sim_infra/MRSP.java 89.65% <100.00%> (-1.53%) ⬇️
...ava/fr/sncf/osrd/standalone_sim/StandaloneSim.java 90.90% <100.00%> (+0.21%) ⬆️

... and 51 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@majaziri majaziri marked this pull request as ready for review March 1, 2023 15:34
axrolld
axrolld previously approved these changes Mar 8, 2023
@axrolld axrolld merged commit eb474ad into dev Mar 10, 2023
@axrolld axrolld deleted the mji/driverbehaviourspeed branch March 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MRSP to take into account driver behavior in speed transitions
3 participants