Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: implements new tabs #3316

Merged
merged 1 commit into from
Feb 28, 2023
Merged

front: implements new tabs #3316

merged 1 commit into from
Feb 28, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Feb 23, 2023

close #3267

@Math-R Math-R requested a review from a team as a code owner February 23, 2023 03:37
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited

Codecov Report

Merging #3316 (3c7d1fc) into dev (74db500) will not change coverage.
The diff coverage is n/a.

❗ Current head 3c7d1fc differs from pull request most recent head 13f6cfe. Consider uploading reports for the commit 13f6cfe to get more accurate results

@@            Coverage Diff            @@
##                dev    #3316   +/-   ##
=========================================
  Coverage     66.86%   66.86%           
  Complexity     1876     1876           
=========================================
  Files           396      396           
  Lines         19106    19106           
  Branches       1488     1488           
=========================================
  Hits          12776    12776           
  Misses         5654     5654           
  Partials        676      676
Flag Coverage Δ
front 52.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Uriel-Sautron
Uriel-Sautron reviewed Feb 23, 2023
View reviewed changes
front/src/styles/scss/_overrideBootstrapSNCF.scss Outdated Show resolved Hide resolved
front/src/common/Tabs.tsx Outdated Show resolved Hide resolved
clarani
clarani reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !! Nothing to add to Uriel's review 😄

Uriel-Sautron
Uriel-Sautron previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!

@Math-R Math-R enabled auto-merge (rebase) February 24, 2023 12:25
anisometropie
anisometropie requested changes Feb 24, 2023
View reviewed changes
front/src/common/Tabs.tsx Outdated Show resolved Hide resolved
@Math-R Math-R force-pushed the mrd/implement-tabs branch 2 times, most recently from 08be017 to 3c7d1fc Compare February 28, 2023 10:45
@Math-R Math-R added the area:front Work on Standard OSRD Interface modules label Feb 28, 2023
@Math-R Math-R merged commit 84e6808 into dev Feb 28, 2023
@Math-R Math-R deleted the mrd/implement-tabs branch February 28, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani left review comments

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@anisometropie anisometropie anisometropie approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement tabs behaviour
5 participants
@Math-R @nicolaswurtz @anisometropie @clarani @Uriel-Sautron