front: fix-bug: set default standard allowance type to percentage instead of time #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3331 +/- ##
=========================================
Coverage 66.87% 66.87%
Complexity 1875 1875
=========================================
Files 396 396
Lines 19095 19095
Branches 1488 1488
=========================================
Hits 12769 12769
Misses 5650 5650
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexandredamiron
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3151
When the STDCM tab is opened from a fresh environment and the standard allowance parameters aren't modified, the front sends a request with a standard allowance of "0 seconds". This is invalid because it's a flat time. It should be either unspecified or set to a percentage value.
The flat time option can't be manually selected anymore, but it's still the default value.
I have modified the default valut to 0%.