Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: debug pathfinding to find the shortest path #3334

Merged
merged 2 commits into from Mar 13, 2023
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 24, 2023

Fix #3319

  • Fix a bug where the shortest path could have an invalid weight if the destination is on the same edge as the origin
  • Use geodesy to compute geographic distances

@eckter eckter requested a review from a team as a code owner February 24, 2023 14:22
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #3334 (fbdc6db) into dev (b7081a7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #3334   +/-   ##
=========================================
  Coverage     68.21%   68.21%           
  Complexity     1897     1897           
=========================================
  Files           411      411           
  Lines         20441    20441           
  Branches       1513     1513           
=========================================
  Hits          13943    13943           
  Misses         5801     5801           
  Partials        697      697           
Flag Coverage Δ
core 79.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../fr/sncf/osrd/railjson/schema/geom/LineString.java 77.55% <ø> (ø)
.../java/fr/sncf/osrd/railjson/schema/geom/Point.java 16.66% <100.00%> (ø)
...ain/java/fr/sncf/osrd/utils/graph/Pathfinding.java 96.03% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eckter eckter marked this pull request as ready for review March 13, 2023 15:58
@eckter eckter merged commit 5965a47 into dev Mar 13, 2023
5 checks passed
@eckter eckter deleted the ech/debug-pathfinding branch March 13, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathfinding doesn't seem to take the shortest path
2 participants