Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: Use cache_duration when setting values in redis #3337

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

bloussou
Copy link
Contributor

This PR is bringing back cache duration for redis values

close #3336

@bloussou bloussou added the area:editoast Work on Editoast Service label Feb 24, 2023
@bloussou bloussou requested a review from a team as a code owner February 24, 2023 16:10
Khoyo
Khoyo previously approved these changes Feb 24, 2023
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #3337 (10d9458) into dev (da2dedc) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##                dev    #3337      +/-   ##
============================================
+ Coverage     66.85%   66.87%   +0.01%     
  Complexity     1876     1876              
============================================
  Files           396      396              
  Lines         19097    19106       +9     
  Branches       1488     1488              
============================================
+ Hits          12768    12777       +9     
  Misses         5653     5653              
  Partials        676      676              
Flag Coverage Δ
editoast 73.84% <60.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/layers/mod.rs 33.87% <0.00%> (-1.73%) ⬇️
editoast/src/map/redis_utils.rs 92.59% <100.00%> (+11.64%) ⬆️
editoast/src/map/bounding_box.rs 29.59% <0.00%> (+1.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou merged commit b46855f into dev Feb 24, 2023
@bloussou bloussou deleted the brieuc/RedisExpirationTime branch February 24, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache duration is not used when setting values in redis
3 participants