Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix linter warnings on generated API client #3354

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Feb 28, 2023

fixes #3355

@anisometropie anisometropie requested a review from a team as a code owner February 28, 2023 11:37
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #3354 (98d1dc8) into dev (eb5d4ea) will increase coverage by 0.63%.
The diff coverage is 89.30%.

@@             Coverage Diff              @@
##                dev    #3354      +/-   ##
============================================
+ Coverage     67.13%   67.77%   +0.63%     
  Complexity     1876     1876              
============================================
  Files           396      396              
  Lines         19108    19660     +552     
  Branches       1498     1498              
============================================
+ Hits          12829    13324     +495     
- Misses         5593     5650      +57     
  Partials        686      686              
Flag Coverage Δ
front 55.29% <89.30%> (+2.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/osrdMiddlewareApi.ts 91.40% <87.44%> (-2.33%) ⬇️
front/src/common/api/osrdEditoastApi.ts 92.53% <97.36%> (+1.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anisometropie anisometropie force-pushed the vcs/eslintignore branch 2 times, most recently from 2ce0a77 to e5ecf7f Compare February 28, 2023 12:02
@anisometropie anisometropie changed the title front: eslint ignores automatically generated openApi files front: fix open api files Feb 28, 2023
front/package.json Outdated Show resolved Hide resolved
front/package.json Outdated Show resolved Hide resolved
front/package.json Outdated Show resolved Hide resolved
front/package.json Outdated Show resolved Hide resolved
front/scripts/generate-types.sh Show resolved Hide resolved
@multun multun changed the title front: fix open api files front: fix linter warnings on generated API client Mar 1, 2023
@nicolaswurtz nicolaswurtz enabled auto-merge (rebase) March 1, 2023 12:14
@multun multun merged commit 7815aa7 into dev Mar 1, 2023
@multun multun deleted the vcs/eslintignore branch March 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make linter compliant openApi files generate automatically
3 participants