Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: migrate light-rolling-stocks endpoints #3442

Merged
merged 1 commit into from
Mar 14, 2023
Merged

editoast: migrate light-rolling-stocks endpoints #3442

merged 1 commit into from
Mar 14, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 8, 2023

closes #3299

@clarani clarani requested a review from a team as a code owner March 8, 2023 14:58
@clarani clarani force-pushed the cni/editoast/migrate-endpoint-get-light-rolling-stock branch 2 times, most recently from 11ee243 to 2deda0c Compare March 8, 2023 15:48
@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited

Codecov Report

Merging #3442 (3450370) into dev (eb474ad) will increase coverage by 0.20%.
The diff coverage is 91.56%.

@@             Coverage Diff              @@
##                dev    #3442      +/-   ##
============================================
+ Coverage     67.92%   68.13%   +0.20%     
  Complexity     1883     1883              
============================================
  Files           405      406       +1     
  Lines         20084    20300     +216     
  Branches       1501     1501              
============================================
+ Hits          13643    13832     +189     
- Misses         5757     5784      +27     
  Partials        684      684
Flag Coverage Δ
editoast 74.37% <92.15%> (+0.24%) ⬆️
front 56.25% <90.62%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/schema/mod.rs 94.44% <ø> (ø)
editoast/src/schema/rolling_stock.rs 88.46% <88.23%> (+0.46%) ⬆️
front/src/common/api/osrdEditoastApi.ts 92.06% <90.62%> (-1.09%) ⬇️
editoast/src/views/light_rolling_stocks.rs 100.00% <100.00%> (ø)
editoast/src/views/mod.rs 95.00% <100.00%> (+0.26%) ⬆️
editoast/src/views/rolling_stocks.rs 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flomonster
flomonster requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/views/light_rolling_stocks.rs Outdated Show resolved Hide resolved
editoast/src/views/light_rolling_stocks.rs Outdated Show resolved Hide resolved
editoast/src/views/rolling_stocks.rs Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni/editoast/migrate-endpoint-get-light-rolling-stock branch from 2deda0c to 060c4ab Compare March 9, 2023 09:11
@clarani clarani force-pushed the cni/editoast/migrate-endpoint-get-light-rolling-stock branch 5 times, most recently from 5e35890 to 1c1caa1 Compare March 10, 2023 15:56
@clarani clarani requested a review from a team as a code owner March 10, 2023 15:56
@flomonster flomonster self-requested a review March 13, 2023 08:59
younesschrifi
younesschrifi requested changes Mar 13, 2023
View reviewed changes
editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
editoast/src/schema/rolling_stock.rs Outdated Show resolved Hide resolved
flomonster
flomonster reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. You didn't use the new document system. Do you plan to do ot in a separated PR later?

@clarani clarani force-pushed the cni/editoast/migrate-endpoint-get-light-rolling-stock branch from 1c1caa1 to 81f0f6f Compare March 13, 2023 15:56
@clarani clarani force-pushed the cni/editoast/migrate-endpoint-get-light-rolling-stock branch from 81f0f6f to 3450370 Compare March 14, 2023 14:44
@clarani
Copy link
Contributor Author

clarani commented Mar 14, 2023 •
edited

You didn't use the new document system. Do you plan to do it in a separated PR later?

It was not planned so far, but yes we can plan it (but it will require a new data import etc, I don't want to do it now). I can open a new ticket

flomonster
flomonster approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your PR 👍

@clarani clarani enabled auto-merge (rebase) March 14, 2023 15:20
@clarani clarani merged commit 6ad9b2c into dev Mar 14, 2023
@clarani clarani deleted the cni/editoast/migrate-endpoint-get-light-rolling-stock branch March 14, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloussou bloussou bloussou left review comments

@flomonster flomonster flomonster approved these changes

@anisometropie anisometropie anisometropie approved these changes

@younesschrifi younesschrifi younesschrifi approved these changes

Assignees

@flomonster flomonster

@Yohh Yohh

@younesschrifi younesschrifi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate GET /light-rolling-stock/ endpoint to editoast
6 participants
@clarani @flomonster @anisometropie @bloussou @younesschrifi @Yohh