Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: replace empty arrow function by lodash noop #3463

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Mar 9, 2023

No description provided.

@sim51 sim51 requested a review from a team as a code owner March 9, 2023 12:31
@sim51 sim51 changed the title front: replace empty arrow function by lodsah noop front: replace empty arrow function by lodash noop Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3463 (2f3b398) into dev (bb239c2) will increase coverage by 0.00%.
The diff coverage is 62.50%.

@@            Coverage Diff            @@
##                dev    #3463   +/-   ##
=========================================
  Coverage     67.73%   67.73%           
  Complexity     1880     1880           
=========================================
  Files           404      404           
  Lines         19940    19943    +3     
  Branches       1501     1501           
=========================================
+ Hits          13506    13509    +3     
  Misses         5750     5750           
  Partials        684      684           
Flag Coverage Δ
front 55.14% <62.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/reducers/osrdsimulation/index.ts 50.26% <33.33%> (+0.26%) ⬆️
front/src/reducers/osrdsimulation/simulation.js 25.67% <50.00%> (+0.28%) ⬆️
...c/common/BootstrapSNCF/ModalSNCF/ModalProvider.tsx 33.53% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea !

@jacomyal jacomyal merged commit 47eab91 into dev Mar 9, 2023
@jacomyal jacomyal deleted the bsi/linter-noop branch March 9, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants